New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A new Thrift binary tool subsystem. #5512

Merged
merged 3 commits into from Feb 24, 2018

Conversation

Projects
None yet
2 participants
@benjyw
Copy link
Contributor

benjyw commented Feb 23, 2018

The new subsytem lives in the codegen/thrift backend.

Deprecates the old ThriftBinary, which was in
the Pants core for some reason.

Also checks that some necessary options in GoThriftGen are set,
replacing a cryptic error with a sensible one. This addresses
#5453.

A new Thrift binary tool subsystem.
The new subsytem lives in the codegen/thrift backend.

Deprecates the old ThriftBinary, which was in
the Pants core for some reason.

@benjyw benjyw requested review from jsirois and stuhood Feb 23, 2018

benjyw added some commits Feb 23, 2018

Still have to register the old subsystem.
So that the old options scope is available.

@benjyw benjyw merged commit 3640e55 into pantsbuild:master Feb 24, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@benjyw benjyw deleted the benjyw:thrift_binary2 branch Feb 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment