Subsystems for the ragel and cloc binaries #5517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also renames protobuf/subsystem -> protobuf/subsystems, for consistency.
stuhood
approved these changes
Feb 25, 2018
| # coding=utf-8 | ||
| # Copyright 2018 Pants project contributors (see CONTRIBUTORS.md). | ||
| # Licensed under the Apache License, Version 2.0 (see LICENSE). | ||
|
|
There was a problem hiding this comment.
Should this file be empty? Ditto the other __init__.py
There was a problem hiding this comment.
D'oh! That's what I get for letting my IDE create files.
| @@ -17,6 +17,8 @@ | |||
|
|
|||
|
|
|||
| class BuildozerBinary(NativeTool): | |||
| # Note: Not in scope 'buildozer' because that's the name of the singleton task | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the new binary tools mechanism.
Also renames protobuf/subsystem -> protobuf/subsystems, for consistency.
There are two commits, one per subsystem, that may be conveniently reviewed separately.