New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set thrifty build_file_aliases #5559

Merged
merged 1 commit into from Mar 6, 2018

Conversation

Projects
None yet
2 participants
@traviscrawford
Copy link
Member

traviscrawford commented Mar 6, 2018

The recently added java_thrifty_library does not have
build_file_aliases set, which makes the new target type inaccessible
in build files. This requirement is already documented in
https://github.com/pantsbuild/pants/blob/master/contrib/README.md so
here we just fix the bug, vs. update the docs too.

Travis Crawford
Set thrifty build_file_aliases
The recently added `java_thrifty_library` does not have
`build_file_aliases` set, which makes the new target type inaccessible
in build files. This requirement is already documented in
https://github.com/pantsbuild/pants/blob/master/contrib/README.md so
here we just fix the bug, vs. update the docs too.
@traviscrawford

This comment has been minimized.

Copy link
Member

traviscrawford commented Mar 6, 2018

@stuhood Thanks for publishing this plugin yesterday! When attempting to use it today I discovered a small bug related to registering the new target type so it's visible in BUILD files. I think this is the fix, and digging around for differences between thrifty and avro wheels (since avro is known good), this was the only difference I could find.

@jsirois

jsirois approved these changes Mar 6, 2018

Copy link
Member

jsirois left a comment

Good catch before the Friday release! I'll merge once this goes green.

@jsirois

This comment has been minimized.

Copy link
Member

jsirois commented Mar 6, 2018

Shard 1 of integration tests appears to be stalling. I may merge this pre-green here and then do the cherry-pick since this change out in contrib/ has no effect on core integration tests.

@jsirois jsirois merged commit 1667c13 into pantsbuild:master Mar 6, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@traviscrawford traviscrawford deleted the traviscrawford:travis/thrifty-build-file-aliases branch Mar 6, 2018

jsirois added a commit to jsirois/pants that referenced this pull request Mar 6, 2018

Set thrifty build_file_aliases (pantsbuild#5559)
The recently added `java_thrifty_library` does not have
`build_file_aliases` set, which makes the new target type inaccessible
in build files. This requirement is already documented in
https://github.com/pantsbuild/pants/blob/master/contrib/README.md so
here we just fix the bug, vs. update the docs too.

stuhood added a commit that referenced this pull request Mar 7, 2018

Set thrifty build_file_aliases (#5559) (#5562)
The recently added `java_thrifty_library` does not have
`build_file_aliases` set, which makes the new target type inaccessible
in build files. This requirement is already documented in
https://github.com/pantsbuild/pants/blob/master/contrib/README.md so
here we just fix the bug, vs. update the docs too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment