New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup and refactor some v1->v2 changed code. #5572

Merged
merged 1 commit into from Mar 7, 2018

Conversation

Projects
None yet
2 participants
@kwlzn
Copy link
Member

kwlzn commented Mar 7, 2018

This marks off some TODO's around non-deprecation-bound 1.5.0 removals and seals the v2 engine variant components into pants.scm from pants.engine.

@kwlzn kwlzn force-pushed the twitter:kwlzn/changed_removal branch from bbb9598 to 1719b5d Mar 7, 2018

@stuhood

stuhood approved these changes Mar 7, 2018

Copy link
Member

stuhood left a comment

Woot. Thanks!

@kwlzn kwlzn force-pushed the twitter:kwlzn/changed_removal branch from 1719b5d to de607e4 Mar 7, 2018

@kwlzn kwlzn merged commit 22ca060 into pantsbuild:master Mar 7, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment