New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send an empty WriteRequest for an empty file #5578

Merged
merged 1 commit into from Mar 9, 2018

Conversation

Projects
None yet
3 participants
@illicitonion
Copy link
Contributor

illicitonion commented Mar 8, 2018

Depends on #5574 - just review the top commit :)

@illicitonion illicitonion requested review from stuhood and ity Mar 8, 2018

@dgassaway
Copy link

dgassaway left a comment

Empty file writerequest change LGTM

@stuhood

stuhood approved these changes Mar 8, 2018

@illicitonion illicitonion force-pushed the twitter:dwagnerhall/emptyuploads branch from 913f71d to 5110b70 Mar 9, 2018

@illicitonion illicitonion merged commit b5c5b7e into pantsbuild:master Mar 9, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@illicitonion illicitonion deleted the twitter:dwagnerhall/emptyuploads branch Apr 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment