New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[coursier] use same artifact cache override as ivy #5586

Merged
merged 1 commit into from Mar 13, 2018

Conversation

Projects
None yet
2 participants
@baroquebobcat
Copy link
Contributor

baroquebobcat commented Mar 13, 2018

Ivy resolve overrides check_artifact_cache_for so that it can ensure the artifact cache is only hit once. This adds that same override to coursier resolve.

Before this change, coursier resolves would check the build cache for each jar library in scope, then throw away that information. When there are hundreds of them, that can take a noticable amount of time. With this change, coursier resolve does one cache hit.

[coursier] use same artifact cache override as ivy
Ivy resolve overrides check_artifact_cache_for so that it can ensure the artifact cache is only hit once. This adds that same override to coursier resolve.

Before this change, coursier resolves would check the build cache for each jar library in scope, then throw away that information. When there are hundreds of them, that can take a noticable amount of time. With this change, coursier resolve does one cache hit.

@baroquebobcat baroquebobcat requested review from stuhood and wisechengyi Mar 13, 2018

@wisechengyi

This comment has been minimized.

Copy link
Contributor

wisechengyi commented Mar 13, 2018

Is there complication with this portion of code?

with self.invalidated(target_subset,
invalidate_dependents=False,
silent=False,
fingerprint_strategy=fp_strategy) as invalidation_check:
if not invalidation_check.all_vts:
continue
pants_workdir = self.get_options().pants_workdir
resolve_vts = VersionedTargetSet.from_versioned_targets(invalidation_check.all_vts)

@baroquebobcat

This comment has been minimized.

Copy link
Contributor

baroquebobcat commented Mar 13, 2018

@wisechengyi
Copy link
Contributor

wisechengyi left a comment

Nice catch @baroquebobcat, thanks!

@baroquebobcat baroquebobcat merged commit 37e775d into pantsbuild:master Mar 13, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wisechengyi wisechengyi added this to the 1.5.x milestone Mar 13, 2018

wisechengyi added a commit that referenced this pull request Mar 14, 2018

[coursier] use same artifact cache override as ivy (#5586)
Ivy resolve overrides check_artifact_cache_for so that it can ensure the artifact cache is only hit once. This adds that same override to Coursier resolve.

Before this change, Coursier resolves would check the build cache for each jar library in scope, then throw away that information. When there are hundreds of them, that can take a noticeable amount of time. With this change, Coursier resolve does one cache hit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment