New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pantsd] Repair stale sources invalidation case. #5589

Merged
merged 2 commits into from Mar 13, 2018

Conversation

Projects
None yet
3 participants
@kwlzn
Copy link
Member

kwlzn commented Mar 13, 2018

Fixes #5588

@kwlzn kwlzn requested a review from stuhood Mar 13, 2018

@kwlzn kwlzn force-pushed the twitter:kwlzn/pantsd_invalidation_test branch from 92ccfe5 to eb87c8a Mar 13, 2018

@kwlzn kwlzn requested a review from wisechengyi Mar 13, 2018

@stuhood

This comment has been minimized.

Copy link
Member

stuhood commented Mar 13, 2018

@kwlzn : Thanks!

Let's land #5590 first, and then you can pull in just the relevant fix from there. I'm 98% certain it was the change in git show b4e8aa27e75a88f634b91cedc6401209b8f6ce68 -- src/python/pants/engine/legacy/structs.py that fixed this.

@wisechengyi
Copy link
Contributor

wisechengyi left a comment

Thanks @kwlzn!

Optionally, you can parse the json output of pants export command, then do assertions on structured data.

@stuhood
Copy link
Member

stuhood left a comment

Thanks for the great investigation here. You should be good to pull the fix itself into this one.

@stuhood stuhood modified the milestones: 1.5.x, 1.4.x Mar 13, 2018

@kwlzn kwlzn force-pushed the twitter:kwlzn/pantsd_invalidation_test branch from eb87c8a to cccb9a6 Mar 13, 2018

@kwlzn kwlzn changed the title [pantsd] Integration test retrofit for stale sources invalidation case. [pantsd] Repair stale sources invalidation case. Mar 13, 2018

@kwlzn kwlzn merged commit 3bae35f into pantsbuild:master Mar 13, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment