New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pre-compiled rustfmt instead of compiling it ourselves #5592

Merged
merged 2 commits into from Mar 13, 2018

Conversation

Projects
None yet
3 participants
@illicitonion
Copy link
Contributor

illicitonion commented Mar 13, 2018

This saves several minutes from a clean build.

Unfortunately, the more-stable formatter has changed, so we get to re-format our code again. On the plus side, the new formatter fixes a lot of issues I have with it...

Use pre-compiled rustfmt instead of compiling it ourselves
This saves several minutes from a clean build.

Unfortunately, the more-stable formatter has changed, so we get to re-format our code again. On the plus side, the new formatter fixes a lot of issues I have with it...

@illicitonion illicitonion requested review from stuhood and kwlzn Mar 13, 2018

@kwlzn

kwlzn approved these changes Mar 13, 2018

@illicitonion illicitonion force-pushed the twitter:dwagnerhall/rustfmt branch from a25e369 to 16e381e Mar 13, 2018

@illicitonion illicitonion merged commit 084a83e into pantsbuild:master Mar 13, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

illicitonion added a commit to twitter/pants that referenced this pull request Mar 14, 2018

Yet more rustfmt
Somehow pantsbuild#5592 only half-formatted the files?

@illicitonion illicitonion referenced this pull request Mar 14, 2018

Merged

Yet more rustfmt #5597

illicitonion added a commit that referenced this pull request Mar 14, 2018

Yet more rustfmt (#5597)
Somehow #5592 only half-formatted the files?

@illicitonion illicitonion deleted the twitter:dwagnerhall/rustfmt branch Apr 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment