New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Materialized files have the executable bit set correctly #5593

Merged
merged 2 commits into from Mar 15, 2018

Conversation

Projects
None yet
2 participants
@illicitonion
Copy link
Contributor

illicitonion commented Mar 13, 2018

No description provided.

@illicitonion illicitonion requested review from stuhood and ity Mar 13, 2018

self
.load_file_bytes_with(digest, move |bytes| {
File::create(&destination)
.and_then(|f| {

This comment has been minimized.

@stuhood

stuhood Mar 14, 2018

Member

Might be able to do one fewer syscall with https://stackoverflow.com/a/28673836 ? But probably too micro.

@illicitonion illicitonion force-pushed the twitter:dwagnerhall/executable branch from 03fcbf5 to 6a59632 Mar 14, 2018

@illicitonion illicitonion merged commit 6518c4c into pantsbuild:master Mar 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@illicitonion illicitonion deleted the twitter:dwagnerhall/executable branch Apr 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment