New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pantsd] Don't compute TargetRoots twice. #5595

Merged
merged 1 commit into from Mar 14, 2018

Conversation

Projects
None yet
3 participants
@kwlzn
Copy link
Member

kwlzn commented Mar 14, 2018

good for a couple of seconds in this synthetic benchmark, potentially more:

[omerta pants (master)]$ pkill -f "pantsd \["
[omerta pants (master)]$ time PANTS_ENABLE_PANTSD=True ./pants --changed-parent=HEAD~100 --changed-include-dependees=transitive list > a 

real    0m24.249s
user    0m1.071s
sys     0m0.736s

vs

[omerta pants (kwlzn/2_chaaaanged)]$ pkill -f "pantsd \["
[omerta pants (kwlzn/2_chaaaanged)]$ time PANTS_ENABLE_PANTSD=True ./pants --changed-parent=HEAD~100 --changed-include-dependees=transitive list > b


real    0m22.667s
user    0m1.080s
sys     0m0.668s

@kwlzn kwlzn requested a review from stuhood Mar 14, 2018

@stuhood
Copy link
Member

stuhood left a comment

Thanks!

Maybe worth mentioning somewhere in a comment that this is primarily a savings because of work that is not executed via the engine, and thus needs to be re-executed post-fork.

@stuhood stuhood added this to the 1.5.x milestone Mar 14, 2018

@kwlzn kwlzn merged commit 07eee72 into pantsbuild:master Mar 14, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

wisechengyi added a commit that referenced this pull request Mar 14, 2018

[pantsd] Don't compute TargetRoots twice. (#5595)
good for a couple of seconds in this synthetic benchmark, potentially more:

[omerta pants (master)]$ pkill -f "pantsd \["
[omerta pants (master)]$ time PANTS_ENABLE_PANTSD=True ./pants --changed-parent=HEAD~100 --changed-include-dependees=transitive list > a 

real    0m24.249s
user    0m1.071s
sys     0m0.736s
vs

[omerta pants (kwlzn/2_chaaaanged)]$ pkill -f "pantsd \["
[omerta pants (kwlzn/2_chaaaanged)]$ time PANTS_ENABLE_PANTSD=True ./pants --changed-parent=HEAD~100 --changed-include-dependees=transitive list > b


real    0m22.667s
user    0m1.080s
sys     0m0.668s
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment