New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert scalafmt test to a unit test. #5599

Merged
merged 1 commit into from Mar 15, 2018

Conversation

Projects
None yet
2 participants
@jsirois
Copy link
Member

jsirois commented Mar 14, 2018

This improves local-readability and knocks down the run-time by 2/3.

Inspired by #5596.

Convert scalafmt test to a unit test.
This improves local-readability and knocks down the run-time by 2/3.

Inspired by #5596.
@illicitonion

This comment has been minimized.

Copy link
Contributor

illicitonion commented Mar 15, 2018

Happy to see the integration test become a unit test, but I think I preferred the scala file being a scala file, rather than a big string in a python file...

@jsirois

This comment has been minimized.

Copy link
Member

jsirois commented Mar 15, 2018

Huh. That's definitely a difference in what we like. I prefer to be able to see everything at once. I could move the file into a resource in the same directory if you object strongly.

@illicitonion
Copy link
Contributor

illicitonion left a comment

I don't object strongly :)

(My rationale is that if I'm viewing or editing the file, I want syntax highlighting and autocomplete and standalone-compilability and such which I get by it being an actual file, so that I can quickly understand what the file is doing and interact with it. I also don't need to think about dedent/escaping/anything because the file is literally the file. Your reasons are totally valid too, though :))

@jsirois jsirois merged commit 0d4212d into pantsbuild:master Mar 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jsirois jsirois deleted the jsirois:ScalaFmt/intg-to-unit branch Mar 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment