New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use readable errno descriptions for lmdb errors #5604

Merged
merged 1 commit into from Mar 15, 2018

Conversation

Projects
None yet
2 participants
@illicitonion
Copy link
Contributor

illicitonion commented Mar 15, 2018

Example output:

otherpants$ ulimit -n 100
otherpants$ RUST_BACKTRACE=1 ./pants list 3rdparty::
thread '<unnamed>' panicked at 'Could not initialize Store directory "Error making env for store at \"/Users/dwagnerhall/.cache/pants/lmdb_store/directories/1\": Too many open files"', src/context.rs:54:27
... stacks follow

This does nothing about the fact that the panic handler swallows error
messages.

Fixes #5600

@illicitonion illicitonion requested review from stuhood , benjyw and kwlzn Mar 15, 2018

Use readable errno descriptions for lmdb errors
Example output:
```
otherpants$ ulimit -n 100
otherpants$ RUST_BACKTRACE=1 ./pants list 3rdparty::
thread '<unnamed>' panicked at 'Could not initialize Store directory "Error making env for store at \"/Users/dwagnerhall/.cache/pants/lmdb_store/directories/1\": Too many open files"', src/context.rs:54:27
... stacks follow
```

This does nothing about the fact that the panic handler swallows error
messages.

@illicitonion illicitonion force-pushed the twitter:dwagnerhall/lmdberrno branch from 8757609 to 21fa29b Mar 15, 2018

@illicitonion illicitonion merged commit 2065abb into pantsbuild:master Mar 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@illicitonion illicitonion deleted the twitter:dwagnerhall/lmdberrno branch Apr 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment