New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robustify `SetupPyIntegrationTest`. #5610

Merged
merged 1 commit into from Mar 17, 2018

Conversation

Projects
None yet
2 participants
@jsirois
Copy link
Member

jsirois commented Mar 17, 2018

Previously, when the pants VERSION was bumped and before publishing
the test_setup_py_unregistered_pants_plugin test would fail to resolve
pantsbuild.pants at the new version on pypi. Update the test to use a
custom-produced pantsbuild.pants distribution and share this logic
with PantsRequirementIntegrationTest.

Similar to #5519 / #5520

Robustify `SetupPyIntegrationTest`.
Previously, when the pants `VERSION` was bumped and before publishing
the `test_setup_py_unregistered_pants_plugin` test would fail to resolve
`pantsbuild.pants` at the new version on pypi. Update the test to use a
custom-produced `pantsbuild.pants` distribution and share this logic
with `PantsRequirementIntegrationTest`.

Similar to #5519

@jsirois jsirois requested review from cosmicexplorer and stuhood Mar 17, 2018

@jsirois

This comment has been minimized.

Copy link
Member

jsirois commented Mar 17, 2018

I'm going to TBR this to unblock the release over in #5607

@jsirois jsirois requested review from dotordogh and ity Mar 17, 2018

@jsirois jsirois merged commit f35e1e6 into pantsbuild:master Mar 17, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jsirois jsirois deleted the jsirois:test_setup_py_integration/fix_pants_requirement branch Mar 17, 2018

@stuhood
Copy link
Member

stuhood left a comment

Thanks John.

stuhood added a commit that referenced this pull request Apr 5, 2018

Ban testprojects/pants-plugins from TestProjectsIntegrationTest. (#5665)
### Problem

These tests were previously stabilized by running against private publishes in #5610 and #5520. But because they were still covered by `TestProjectsIntegrationTest` (outside the context of the private publish), they failed there instead.

### Solution

Ban them from `TestProjectsIntegrationTest`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment