Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Memoize org.scalatest.Suite class loading #5614
JUnit runner has very long hangs when running many tests in our repo (around 5 minutes). The line that it seems to be hanging on is the class loading of
It might be a deadlock, or it might be that the reflection is just slow... either way, saving the result of the class load avoids the extra work and fixes the issue.
I should note that another (maybe more straightforward) solution is to reference
The hang is gone!
Weird, I might be reading this wrong but this error is in a file that I didn't touch
Also I don't actually see any 100+ character lines in that file.
Ok so I was able to repro the failure
so the issue is that the CI server is rewriting the code with
I'm going to open an issue with more details.
referenced this pull request
Mar 22, 2018
left a comment
The doc updates look good and thanks for moving the runner class lookup too!
I reread my comment and I don't think I was as clear as I could have been. I don't consider assertions/tests about the class loaders to be a blocker for landing this because we have decent test coverage, that's not an issue we've run into before, and this is probably not the only place that would be affected.