New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop example fsnotify dep #5619

Merged
merged 1 commit into from Mar 21, 2018

Conversation

Projects
None yet
2 participants
@stuhood
Copy link
Member

stuhood commented Mar 21, 2018

Problem

The fsnotify golang dep no longer appears to be used transitively... and yet somehow still seems to be failing to resolve.

Solution

Remove it.

Drop a golang dep that no longer appears to be used transitively... a…
…nd yet somehow still seems to be failing.

@stuhood stuhood changed the title WIP: Drop example fsnotify dep Drop example fsnotify dep Mar 21, 2018

@stuhood stuhood requested review from jsirois , benjyw and kwlzn Mar 21, 2018

@stuhood

This comment has been minimized.

Copy link
Member

stuhood commented Mar 21, 2018

Reviewable.

@stuhood stuhood requested a review from mateor Mar 21, 2018

@stuhood

This comment has been minimized.

Copy link
Member

stuhood commented Mar 21, 2018

(see #5614 for the failure this causes)

@stuhood

This comment has been minimized.

Copy link
Member

stuhood commented Mar 21, 2018

Going to merge --tbr to fix master.

@stuhood stuhood merged commit 32de7ed into pantsbuild:master Mar 21, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stuhood stuhood deleted the twitter:stuhood/drop-stale-go-dep branch Mar 21, 2018

@benjyw
Copy link
Contributor

benjyw left a comment

LG, pending investigation of what's going on? Or is it clear?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment