New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump coursier version to 1.1.0.cf365ea27a710d5f09db1f0a6feee129aa1fc417 #5625

Merged
merged 1 commit into from Mar 24, 2018

Conversation

Projects
None yet
4 participants
@wisechengyi
Copy link
Contributor

wisechengyi commented Mar 24, 2018

Corresponding to coursier/coursier@cf365ea

@wisechengyi wisechengyi changed the title Bump coursier version to 1.1.0.https://github.com/coursier/coursier/commit/cf365ea27a710d5f09db1f0a6feee129aa1fc417 Bump coursier version to 1.1.0.cf365ea27a710d5f09db1f0a6feee129aa1fc417 Mar 24, 2018

@kwlzn

kwlzn approved these changes Mar 24, 2018

@@ -36,14 +36,14 @@ def register_options(cls, register):
register('--fetch-options', type=list, fingerprint=True,
help='Additional options to pass to coursier fetch. See `coursier fetch --help`')
register('--bootstrap-jar-url', fingerprint=True,
default='https://dl.dropboxusercontent.com/s/t8zz2nupqkv2sfv/coursier-cli-1.0.2.e943c8069180d22f352878949f9522ad91d89026.jar?dl=0',
default='https://dl.dropboxusercontent.com/s/zwh074l9kxhqlwp/coursier-cli-1.1.0.cf365ea27a710d5f09db1f0a6feee129aa1fc417.jar?dl=0',

This comment has been minimized.

@kwlzn

kwlzn Mar 24, 2018

Member

was surprised to see this default option pointing to an arbitrary dropbox URL.

is there no better location to host this jar?

This comment has been minimized.

@wisechengyi

wisechengyi Mar 24, 2018

Contributor

Temp solution. Will be part of the cleanup to move to binutil once we get this out of the door.

This comment has been minimized.

@stuhood

stuhood Mar 26, 2018

Member

@wisechengyi : Sorry, I've asked this before, but: is there any plan for upstream to begin publishing the CLI? Can we link to it as a TODO/github issue?

This comment has been minimized.

@baroquebobcat

baroquebobcat Mar 26, 2018

Contributor

It is being published http://www.maven.org/#search%7Cgav%7C1%7Cg%3A%22io.get-coursier%22%20AND%20a%3A%22coursier-cli_2.12%22. We could check the most recent version to verify it includes our changes and switch to that.

This comment has been minimized.

@wisechengyi

wisechengyi Mar 27, 2018

Contributor

Yep. plan to take a look at that soon.

@wisechengyi wisechengyi merged commit 203a7e6 into pantsbuild:master Mar 24, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wisechengyi wisechengyi deleted the wisechengyi:update_coursier branch Mar 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment