New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore and modernize `--changed` tests #5635

Merged
merged 2 commits into from Mar 28, 2018

Conversation

Projects
None yet
3 participants
@stuhood
Copy link
Member

stuhood commented Mar 27, 2018

Problem

All tests of the --changed functionality were accidentally deleted in #5337.

Solution

Restore and modernize the tests by removing references to the changed goals.

@stuhood stuhood requested review from benjyw and kwlzn Mar 27, 2018

@kwlzn

kwlzn approved these changes Mar 27, 2018

Copy link
Member

kwlzn left a comment

thanks!

@benjyw

benjyw approved these changes Mar 27, 2018

@stuhood

This comment has been minimized.

Copy link
Member

stuhood commented Mar 28, 2018

Flakiness in the OSX shard. Merging.

@stuhood stuhood merged commit 2ecc367 into pantsbuild:master Mar 28, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@stuhood stuhood deleted the twitter:stuhood/restore-changed-tests branch Mar 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment