Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fail for deleted-but-depended-on targets in changed #5636
#5579 broke detection of deleted targets.
As described in #382 (mega classic!), it might be possible to more deeply integrate change detection into the v2 engine itself to compute a delta on the graph. But for now we defer a deeper solution and simply ensure that we fail for deleted targets by transitively expanding targets. Adds a test to cover the behaviour.
Due to fully hydrating targets, this represents a linear performance regression from #5579: the runtime of
The impact for exactly that step is constant, and fairly high:
... but the impact on overall runtime is dependent on the count of targets that are transitively affected, because for all affected targets, we're going to need to compute transitive roots anyway. So for the example change from #5579 which affects 567 targets:
For a change impacting only 14 targets the difference is slightly more pronounced: