New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include rust stdlib sources in bootstrap. #5645

Merged
merged 1 commit into from Apr 2, 2018

Conversation

Projects
None yet
3 participants
@jsirois
Copy link
Member

jsirois commented Apr 2, 2018

These make it easier to setup a self-contained and consistent
development environment for hacking on the Pants rust codebase.

Include rust stdlib sources in bootstrap.
These make it easier to setup a self-contained and consistent
development environment for hacking on the Pants rust codebase.

@jsirois jsirois requested a review from stuhood Apr 2, 2018

@kwlzn

kwlzn approved these changes Apr 2, 2018

@jsirois jsirois merged commit 8799881 into pantsbuild:master Apr 2, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jsirois jsirois deleted the jsirois:jsirois/rust/dev-env branch Apr 2, 2018

@illicitonion

This comment has been minimized.

Copy link
Contributor

illicitonion commented Apr 9, 2018

I'm curious about what this actually provides - how are you using this?

@jsirois

This comment has been minimized.

Copy link
Member

jsirois commented Apr 9, 2018

I point Intellij at these sources and then get proper linking when I want to inspect stdlib sources (or docs).

@illicitonion

This comment has been minimized.

Copy link
Contributor

illicitonion commented Apr 9, 2018

Cool, thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment