New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release script cleanups. #5650

Merged
merged 1 commit into from Apr 3, 2018

Conversation

Projects
None yet
3 participants
@jsirois
Copy link
Member

jsirois commented Apr 3, 2018

Fix local readonly, which declares a bash local variable, but does
not actually make it readonly. Also DRY up VERSION_FILE use in one
straggler and allow origin git urls that elide the .git suffix.

Release script cleanups.
Fix `local readonly`, which declares a bash local variable, but does
not actually make it readonly. Also DRY up `VERSION_FILE` use in one
straggler and allow origin git urls that elide the `.git` suffix.
@jsirois

This comment has been minimized.

Copy link
Member

jsirois commented Apr 3, 2018

Minor cleanups discovered working #4558

@jsirois jsirois requested review from cosmicexplorer and kwlzn Apr 3, 2018

@@ -322,7 +321,9 @@ function dry_run_install() {

ALLOWED_ORIGIN_URLS=(

This comment has been minimized.

@cosmicexplorer

cosmicexplorer Apr 3, 2018

Contributor

nice!

@cosmicexplorer
Copy link
Contributor

cosmicexplorer left a comment

Good, useful change! As much as I like shell scripts, I think #5551 is a good direction to move in general for this kind of reason.

@kwlzn

kwlzn approved these changes Apr 3, 2018

@jsirois jsirois merged commit 26f839a into pantsbuild:master Apr 3, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jsirois jsirois deleted the jsirois:issues/4558/release_cleanups branch Apr 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment