New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle `native_engine.so` resources without headers. #5653

Merged
merged 1 commit into from Apr 4, 2018

Conversation

Projects
None yet
2 participants
@jsirois
Copy link
Member

jsirois commented Apr 4, 2018

Previously, although bootstrapping worked fine when a native_engine.so
resource file was present without headers (switching from an old branch
to a newer one), reading the 1st line from the headerless resource
emitted the following warning to stderr:
warning: command substitution: ignored null byte in input

Tighten up the script to handle these cases more gracefully by scrubbing
null bytes.

Handle `native_engine.so` resources without headers.
Previously, although bootstrapping worked fine when a `native_engine.so`
resource file was present without headers (switching from an old branch
to a newer one), reading the 1st line from the headerless resource
emitted the following warning to stderr:
  warning: command substitution: ignored null byte in input

Tighten up the script to handle these cases more gracefully by scrubbing
null bytes.
@jsirois

This comment has been minimized.

Copy link
Member

jsirois commented Apr 4, 2018

Cleans up after #5649

@jsirois jsirois requested review from kwlzn and dotordogh Apr 4, 2018

@kwlzn

kwlzn approved these changes Apr 4, 2018

@jsirois jsirois merged commit 37b9ec0 into pantsbuild:master Apr 4, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jsirois jsirois deleted the jsirois:pull/5649/cleanup branch Apr 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment