New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ban testprojects/pants-plugins from TestProjectsIntegrationTest #5665

Merged
merged 1 commit into from Apr 5, 2018

Conversation

Projects
None yet
3 participants
@stuhood
Copy link
Member

stuhood commented Apr 5, 2018

Problem

These tests were previously stabilized by running against private publishes in #5610 and #5520. But because they were still covered by TestProjectsIntegrationTest (outside the context of the private publish), they failed there instead.

Solution

Ban them from TestProjectsIntegrationTest.

Ban testprojects/pants-plugins from `TestProjectsIntegrationTest` cov…
…erage, since they are version dependent.

@stuhood stuhood requested review from jsirois , wisechengyi and kwlzn Apr 5, 2018

@kwlzn

kwlzn approved these changes Apr 5, 2018

@stuhood stuhood merged commit 2d658f0 into pantsbuild:master Apr 5, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@stuhood stuhood deleted the twitter:stuhood/ban-pants-plugins-tests-from-project-coverage branch Apr 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment