New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shader to not shade .class files under META-INF directory #5671

Merged
merged 1 commit into from Apr 6, 2018

Conversation

Projects
None yet
2 participants
@cheister
Copy link
Contributor

cheister commented Apr 6, 2018

Problem

If a jar contained a class file under META-INF than the shader would try to relocate it.

Solution

Fix the conditional in _potential_package_path to exclude class files in META-INF

Result

The shader no longer tries to shade class files under META-INF

@cheister cheister requested a review from stuhood Apr 6, 2018

@cheister

This comment has been minimized.

Copy link
Contributor

cheister commented Apr 6, 2018

The extra debug logging for the shader can be removed if you think it is too verbose. It helped tracking down this problem but usually outputs a lot of rules.

@stuhood

stuhood approved these changes Apr 6, 2018

@cheister cheister merged commit 3451463 into pantsbuild:master Apr 6, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@cheister cheister deleted the cheister:dont-shade-class-files-under-meta-inf branch Apr 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment