New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup `unused_parens` warning for cast. #5677

Merged
merged 1 commit into from Apr 9, 2018

Conversation

Projects
None yet
3 participants
@jsirois
Copy link
Member

jsirois commented Apr 9, 2018

The warning looked like so:

   Compiling process_execution v0.0.1 (file:///home/jsirois/dev/pantsbuild/jsirois-pants/src/rust/engine/process_execution)
warning: unnecessary parentheses around function argument
   --> src/nodes.rs:729:28
    |
729 |         externs::store_i32((item.digest.1 as i32)),
    |                            ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
    |
    = note: #[warn(unused_parens)] on by default
Cleanup `unused_parens` warning for cast.
The warning looked like so:
```
   Compiling process_execution v0.0.1 (file:///home/jsirois/dev/pantsbuild/jsirois-pants/src/rust/engine/process_execution)
warning: unnecessary parentheses around function argument
   --> src/nodes.rs:729:28
    |
729 |         externs::store_i32((item.digest.1 as i32)),
    |                            ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
    |
    = note: #[warn(unused_parens)] on by default
```

@jsirois jsirois requested review from illicitonion and stuhood Apr 9, 2018

@jsirois

This comment has been minimized.

Copy link
Member

jsirois commented Apr 9, 2018

I'm hoping the OSX shard is fixed by #5679 - submitting as-is.

@jsirois jsirois merged commit e92dd10 into pantsbuild:master Apr 9, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@jsirois jsirois deleted the jsirois:rust/1.25.0/fixup_warning branch Apr 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment