New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.7.0 deprecations #5681

Merged
merged 19 commits into from Apr 13, 2018

Conversation

Projects
None yet
5 participants
@benjyw
Copy link
Contributor

benjyw commented Apr 9, 2018

Best to review each commit separately.

@benjyw

This comment has been minimized.

Copy link
Contributor

benjyw commented Apr 9, 2018

There are a couple more deprecations not handled in this pull request: I left the node plugin alone because it's being refactored anyway by @UnrememberMe , and there's a relatively non-trivial one for leveled_predicate in build_graph.py, that I will leave to @baroquebobcat .

@benjyw benjyw requested a review from stuhood Apr 9, 2018

@stuhood

stuhood approved these changes Apr 9, 2018

Copy link
Member

stuhood left a comment

Awesome @benjyw : all of this looks good.

Guessing that we have a bunch more dead code after the IDE removal!

@kwlzn

kwlzn approved these changes Apr 9, 2018

@benjyw

This comment has been minimized.

Copy link
Contributor

benjyw commented Apr 9, 2018

@wisechengyi

This comment has been minimized.

Copy link
Contributor

wisechengyi commented Apr 9, 2018

Yes it is very much in active use. Please kindly remove the deprecation Please leave it untouched

benjyw added some commits Apr 9, 2018

register('--closure', type=bool,
removal_version='1.7.0.dev0', removal_hint='Use --transitive instead.',
help='Eval all targets in the closure individually instead of just the targets '
'specified on the command line.')

This comment has been minimized.

@baroquebobcat

This comment has been minimized.

@benjyw

benjyw Apr 10, 2018

Contributor

D'oh, of course.

benjyw added some commits Apr 10, 2018

@baroquebobcat
Copy link
Contributor

baroquebobcat left a comment

Looks good!

@benjyw benjyw merged commit 2d1a7c0 into pantsbuild:master Apr 13, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@benjyw benjyw deleted the benjyw:1.7.0-deprecations branch Apr 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment