New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part 1: Add ability to check what CAS blobs are missing #5686

Merged
merged 3 commits into from Apr 10, 2018

Conversation

Projects
None yet
3 participants
@dotordogh
Copy link
Contributor

dotordogh commented Apr 10, 2018

Problem

This is the first part of #5505. Paired with @illicitonion on this :)

@dotordogh dotordogh requested a review from illicitonion Apr 10, 2018

@illicitonion
Copy link
Contributor

illicitonion left a comment

LGTM

Leaving overnight in case anyone else wants to jump in on review

@@ -1505,6 +1508,29 @@ mod remote {
)).to_boxed() as BoxFuture<_, _>,
}
}

pub fn list_missing_digests(&self, digests: Vec<Digest>) -> Result<Vec<Digest>, String> {

This comment has been minimized.

@illicitonion

illicitonion Apr 10, 2018

Contributor

Oh, actually, one thing... This probably wants to return a HashSet<Digest> rather than a Vec<Digest>. Should be a trivial change (though slightly awkward for the tests) :)

(Also, I suspect that now that this is returning a Result rather than a BoxFuture, you no longer need the type hint on the collect).

Dorothy Ordogh
@baroquebobcat
Copy link
Contributor

baroquebobcat left a comment

lgtm!

@illicitonion illicitonion merged commit 37c2be3 into pantsbuild:master Apr 10, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment