New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset LMDB Environments when forking #5689

Merged
merged 1 commit into from Apr 12, 2018

Conversation

Projects
None yet
3 participants
@illicitonion
Copy link
Contributor

illicitonion commented Apr 12, 2018

No description provided.

@illicitonion illicitonion requested review from stuhood and kwlzn Apr 12, 2018

@stuhood stuhood added this to the 1.6.x milestone Apr 12, 2018

@stuhood
Copy link
Member

stuhood left a comment

Thanks!

@stuhood stuhood merged commit 752fa5c into pantsbuild:master Apr 12, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

stuhood added a commit that referenced this pull request Apr 12, 2018

@kwlzn

This comment has been minimized.

Copy link
Member

kwlzn commented Apr 13, 2018

could it make sense to circle back with an integration test that ensures two parallel pantsd-based runs can complete simultaneously as future-proofing for the general case of non-fork-safe-locking-based regressions?

@illicitonion illicitonion deleted the twitter:dwagnerhall/lmdb/forking branch Apr 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment