New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use absolute path to check_rust_formatting #5694

Merged
merged 1 commit into from Apr 13, 2018

Conversation

Projects
None yet
2 participants
@illicitonion
Copy link
Contributor

illicitonion commented Apr 13, 2018

The script outputs its own path as a suggestion to run, which is incorrect if you're not in the repo root.

@stuhood
Copy link
Member

stuhood left a comment

Ditto import sort order below.

Use absolute path to check_rust_formatting
The script outputs its own path as a suggestion to run, which is incorrect if you're not in the repo root.

@illicitonion illicitonion force-pushed the twitter:dwagnerhall/rustfmtscript branch from 5408b99 to c92c8e1 Apr 13, 2018

@illicitonion illicitonion merged commit 64c09e1 into pantsbuild:master Apr 13, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@illicitonion illicitonion deleted the twitter:dwagnerhall/rustfmtscript branch Apr 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment