New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dedupe parsed Gets #5700

Merged
merged 2 commits into from Apr 24, 2018

Conversation

Projects
None yet
4 participants
@stuhood
Copy link
Member

stuhood commented Apr 14, 2018

Problem

Rules containing two Gets for the same product/subject pair experience a panic during RuleGraph construction time.

Solution

Dedupe Get requests.

@cosmicexplorer

This comment has been minimized.

Copy link
Contributor

cosmicexplorer commented Apr 14, 2018

Not trying to be pedantic, is this something we would want to add a test for? It feels like having a suite of v2 test projects which we expect to work and just running some product requests against them as integration tests might have caught this sooner. Would that be a useful thing to have?

@illicitonion
Copy link
Contributor

illicitonion left a comment

Definitely agree that a test would be good here.

@stuhood stuhood force-pushed the twitter:stuhood/dedupe-gets branch from 4571883 to ca21abf Apr 24, 2018

@stuhood stuhood merged commit aacad75 into pantsbuild:master Apr 24, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stuhood stuhood deleted the twitter:stuhood/dedupe-gets branch Apr 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment