Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
convert usages of the ExecuteProcess helper into simple @rules to simplify snapshot consumption for process execution #5703
I find the use of functools in the ExecuteProcess and SnapshottedProcess helpers very difficult to follow (see here).
Convert the usages of ExecuteProcess helper into a series of
Several examples of implementing isolated process execution with
I'm also going to look into the same kind of change for SnapshottedProcess -- that would probably involve changes to the snapshot manipulation API (see #5502) as well.
This is actually done as of f2beed0, but I'm also trying to resolve the fixme I left in 7f9f4ee, and after I remove the
This is because
However, I can't figure out how to edit that branch of the
This above bit should probably go into a separate PR, so for the time being I'm going to revert to f2beed0 so the point of this PR is clear.
This question is an excellent one... sorry that
We're currently matching the requested product type and then assuming something about the subject based on that. Instead of assuming the subject type, what we should do instead is first make a request for
left a comment
This looks great, thanks for putting it together!!
Feel free to delete absolutely as much of the old code here as you want, e.g. the entirety of
left a comment
This looks great!
Pretty much just more stuff to delete :)
More symbols to delete: