New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move From impls from hashing to bazel_protos #5706

Merged
merged 1 commit into from Apr 27, 2018

Conversation

Projects
None yet
2 participants
@illicitonion
Copy link
Contributor

illicitonion commented Apr 16, 2018

hashing should be a nice quick/easy/small thing to compile, which
shouldn't rely on protocol buffer compilation because it just has a
couple of value types in.

bazel_protos already needs to depend on protocol buffer compilation.

Move From impls from hashing to bazel_protos
hashing should be a nice quick/easy/small thing to compile, which
shouldn't rely on protocol buffer compilation because it just has a
couple of value types in.

bazel_protos already needs to depend on protocol buffer compilation.

@illicitonion illicitonion requested review from ity and dotordogh Apr 16, 2018

@illicitonion illicitonion requested a review from jsirois Apr 27, 2018

@illicitonion illicitonion merged commit b9d3ef7 into pantsbuild:master Apr 27, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@illicitonion illicitonion deleted the twitter:dwagnerhall/movefromimpl branch Apr 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment