New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some errorprone warnings and remove duplicates from findbugs targets #5711

Merged
merged 1 commit into from Apr 17, 2018

Conversation

Projects
None yet
2 participants
@cheister
Copy link
Contributor

cheister commented Apr 16, 2018

Problem

The latest errorprone has more warnings than the current version Pants is running on. We also potentially run findbugs on the same target twice.

Solution

This cleans up new warnings from errorprone 2.2.0 and removes duplicates from the findbugs targets.

Result

It will reduce the amount of changes in code when we update to errorprone 2.2.0

@cheister cheister requested a review from stuhood Apr 16, 2018

@illicitonion
Copy link
Contributor

illicitonion left a comment

Looks great! Thanks for the clean-up!

One minor question, then I'm happy to merge :)

String specString = DUMMY_CLASS_NAME + "#" + DUMMY_METHOD_NAME;
SpecParser parser = new SpecParser(ImmutableList.of(DUMMY_CLASS_NAME, specString));

This comment has been minimized.

@illicitonion

illicitonion Apr 17, 2018

Contributor

Why did this order need to change?

This comment has been minimized.

@cheister

cheister Apr 17, 2018

Contributor

The test wasn't working before and adding the fail() made the test fail. The order needed to be changed to get the test to pass.

@illicitonion illicitonion merged commit 521980e into pantsbuild:master Apr 17, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@cheister cheister deleted the cheister:errorprone-cleanup branch Apr 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment