New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

java_agent gets added to manifest for java_binary targets #5722

Merged
merged 2 commits into from Apr 19, 2018

Conversation

Projects
None yet
3 participants
@illicitonion
Copy link
Contributor

illicitonion commented Apr 18, 2018

Right now we never traverse deps, so java_agent never actually works
today. But now there's a test! :)

java_agent gets added to manifest for java_binary targets
Right now we never traverse deps, so java_agent never actually works
today. But now there's a test! :)

@illicitonion illicitonion requested review from jsirois and benjyw Apr 18, 2018

@baroquebobcat
Copy link
Contributor

baroquebobcat left a comment

Hooray tests! Looks good, I've got one commenting comment.

@@ -445,6 +442,9 @@ def add_target(self, target, recursive=False):
elif agents:
self._add_agent_manifest(agents[0], self._manifest)
products_added = True
elif isinstance(target, JavaAgent):
self._add_agent_manifest(target, self._manifest)
products_added = True

This comment has been minimized.

@baroquebobcat

baroquebobcat Apr 19, 2018

Contributor

I think this'd be a little easier to follow if there were a comment above the conditional block here pointing out that it is responsible for adding an agent if it exists.

This comment has been minimized.

@illicitonion

illicitonion Apr 19, 2018

Contributor

Good call :) Done

@illicitonion illicitonion merged commit 871b8e7 into pantsbuild:master Apr 19, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@illicitonion illicitonion deleted the twitter:dwagnerhall/javaagent branch Apr 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment