Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add interpreter identity check for non-blacklisted interpreters #5724
The pex resolver blacklist checking in the Pants codebase is too loose and only checks that a requirement name is present in the blacklist before excluding it from the pex builder object. Requirements blacklisted by pants.ini do not get their requirement strings plumbed though to the PEX-INFO metadata of produced pex files and as a result, these pex files cannot import the dependencies they need.
Check for interpreter identity matches before excluding requirements from the pex builder object in addition to the requirement name check.
Pex files that use a non-blacklisted interpreter for a particular requirement will not have that requirement excluded from PEX-INFO metadata, hence making the requirement importable in the scripts packaged by the pex file.