Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Update errorprone to 2.3.0 and findbugs to spotbugs 3.1.3 #5725
Pants was on older versions of Errorprone and Findbugs (now SpotBugs) that did not run on Java 9+
Update errorprone and findbugs so they work on Java 9 and 10.
Both are updated. I didn't think the noise of renaming findbugs to spotbugs made sense in this change. I also assumed it is ok that they require Java 8 as a minimum runtime even though Pants still supports Java 7.
Not sure what is going on in Travis.
I thought maybe there was test pollution in the shard but running the whole shard locally also passed.
Any ideas? I could comment out the test from CI but that seems odd considering it's passing locally.