New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump max local store size #5728

Merged
merged 1 commit into from Apr 20, 2018

Conversation

Projects
None yet
3 participants
@illicitonion
Copy link
Contributor

illicitonion commented Apr 20, 2018

If you exceed this limit, all writes fail, and 256M per shard is a pretty low limit.

@illicitonion illicitonion requested a review from stuhood Apr 20, 2018

@stuhood
Copy link
Member

stuhood left a comment

Thanks!

const MAX_LOCAL_STORE_SIZE_BYTES: usize = 4 * 1024 * 1024 * 1024;
// This is the maximum size any particular local LMDB store file is allowed to grow to.
// It doesn't reflect space allocated on disk, or RAM allocated (it may be reflected in VIRT but
// not RSS). There is no practical upper bound on this number, so we sit it ridiculously high.

This comment has been minimized.

@stuhood

@stuhood stuhood added this to the 1.6.x milestone Apr 20, 2018

Bump max local store size
If you exceed this limit, all writes fail, and 256M per shard is a pretty low limit.

@illicitonion illicitonion force-pushed the twitter:dwagnerhall/lmdb/sizebound branch from e69b344 to 9360529 Apr 20, 2018

@illicitonion illicitonion merged commit 305f1db into pantsbuild:master Apr 20, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

stuhood added a commit that referenced this pull request Apr 20, 2018

Bump max local store size (#5728)
If you exceed this limit, all writes fail, and 256M per shard is a pretty low limit.

stuhood added a commit to twitter/pants that referenced this pull request Apr 20, 2018

@illicitonion illicitonion deleted the twitter:dwagnerhall/lmdb/sizebound branch Apr 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment