New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract reusable test data #5737

Merged
merged 2 commits into from Apr 24, 2018

Conversation

Projects
None yet
2 participants
@illicitonion
Copy link
Contributor

illicitonion commented Apr 23, 2018

Rather than having implicit relationships between bytes/Directories and
their digests, make them explicit.

Reduce re-creating the same things.

Extract reusable test data
Rather than having implicit relationships between bytes/Directories and
their digests, make them explicit.

Reduce re-creating the same things.

@illicitonion illicitonion requested review from stuhood , ity and dotordogh Apr 23, 2018

@dotordogh
Copy link
Contributor

dotordogh left a comment

Amazing!! Thank you!!

// Directory structure:
//
// /cats/roland
// /treats

This comment has been minimized.

@dotordogh

dotordogh Apr 24, 2018

Contributor

If I'm reading this correctly, this dir doesn't contain /treats...

This comment has been minimized.

@illicitonion

illicitonion Apr 24, 2018

Contributor

Sorry I lied about treats :(

@illicitonion illicitonion merged commit d25879b into pantsbuild:master Apr 24, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@illicitonion illicitonion deleted the twitter:dwagnerhall/testdata branch Apr 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment