New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using tools.jar for JAXB xjc tool since tools.jar has been removed from Java 9+ #5740

Merged
merged 1 commit into from Apr 24, 2018

Conversation

Projects
None yet
2 participants
@cheister
Copy link
Contributor

cheister commented Apr 23, 2018

Problem

The jaxb codegen tool relies on tools.jar which was removed in Java 9

Solution

Use explicit com.sun.xml.bind jars for the jaxb-xjc tool instead

Result

The jax-xjc tool will run on Java 9+

@cheister cheister requested a review from stuhood Apr 23, 2018

@cheister cheister force-pushed the cheister:no-tool-jar-for-jaxb-gen branch from 706fbe6 to 4db89e0 Apr 24, 2018

@stuhood
Copy link
Member

stuhood left a comment

Thanks!

classpath=[
JarDependency(org='com.sun.xml.bind',
name='jaxb-core',
rev='2.3.0'),

This comment has been minimized.

@stuhood

stuhood Apr 24, 2018

Member

Are the 2.3.0 values all associated? Would be good to have a shared local variable for them.

@cheister cheister force-pushed the cheister:no-tool-jar-for-jaxb-gen branch from 4db89e0 to 71147e0 Apr 24, 2018

@cheister cheister merged commit 08c4136 into pantsbuild:master Apr 24, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@cheister cheister deleted the cheister:no-tool-jar-for-jaxb-gen branch Apr 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment