Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Hermeticize cargo build. #5742
The cargo build is now hermetic in order to be transparent to
3 times, most recently
Apr 24, 2018
left a comment
Thanks for putting this together, it generally looks great, and a lot better than what was there before :)
Could you add a README.md in build-support/bin/native, or add to the one in src/rust/engine, which explains roughly what is now found in there and why? I can see someone wanting to quickly work out what's going on there, and reading through all of the scripts will be a lot of context gathering to answer simple questions.
I'm not entirely convinced by the changes to protobuf generation. I think what you've got here is a lot harder to read and reason about than what we currently have. Can you talk through the concrete benefits it provides?
Good idea, will do.
This may be another eye of the beholder. Prior to this change part of the knowledge of protbuf paths is in
Here, as much of the logic as possible is self-contained with only the binary download of protoc shelled out. Its true the logic is still spread between multiple bits. Prior to this change, it was
Yeah, I can see where you're coming from :) Particularly with the codegen'd mod.rs.
I think the reason I found the status quo simpler is because the shell script (which I find pretty easy to just read and see what it does) encapsulates all of the "what am I doing" logic pretty cleanly, and the build.rs is just a tiny "run the shell script" wrapper, but I can see that the hidden "fetch and install some binaries" piece in bootstrapping, and the magical