New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save noop time on codegen #5748

Merged
merged 2 commits into from Apr 26, 2018

Conversation

Projects
None yet
3 participants
@wisechengyi
Copy link
Contributor

wisechengyi commented Apr 25, 2018

Before

$ for i in `seq 1 5`; do ./pants --time compile 2>&1 | grep 'Critical Path' -A 20 | grep main:gen; done
0.706 main:gen
0.603 main:gen
0.652 main:gen
0.601 main:gen
0.667 main:gen

After

$ for i in `seq 1 5`; do ./pants --time compile 2>&1 | grep 'Critical Path' -A 20 | grep main:gen; done
0.168 main:gen
0.156 main:gen
0.163 main:gen
0.163 main:gen
0.157 main:gen

wisechengyi added some commits Apr 25, 2018

wat

@wisechengyi wisechengyi requested review from stuhood and baroquebobcat Apr 25, 2018

@stuhood

This comment has been minimized.

Copy link
Member

stuhood commented Apr 25, 2018

What is expensive about this? Can it be short circuited at a deeper level, such as in implementation of the invalidated block?

@wisechengyi

This comment has been minimized.

Copy link
Contributor

wisechengyi commented Apr 25, 2018

yeah possible. I can try that

@wisechengyi

This comment has been minimized.

Copy link
Contributor

wisechengyi commented Apr 25, 2018

Dug a little, given how invalidated block needs to yield a thing, it is going to be more intrusive and risky to do so with invalidated.

@wisechengyi wisechengyi merged commit 2287e3a into pantsbuild:master Apr 26, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wisechengyi wisechengyi deleted the wisechengyi:shave branch Apr 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment