New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boxable::to_boxed returns BoxFuture not Box<Self> #5754

Merged
merged 1 commit into from Apr 26, 2018

Conversation

Projects
None yet
3 participants
@illicitonion
Copy link
Contributor

illicitonion commented Apr 26, 2018

This trait only exists to return BoxFutures, and doing this means we no
longer need to explicitly ascribe types for the typechecker.

Boxable::to_boxed returns BoxFuture not Box<Self>
This trait only exists to return BoxFutures, and doing this means we no
longer need to explicitly ascribe types for the typechecker.

@illicitonion illicitonion requested review from stuhood and jsirois Apr 26, 2018

@stuhood
Copy link
Member

stuhood left a comment

Huzzah!

@illicitonion illicitonion merged commit 1acaeec into pantsbuild:master Apr 26, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@illicitonion illicitonion deleted the twitter:dwagnerhall/boxfuture branch Apr 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment