New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding compile scopes, because thats expected from doc gen #5789

Merged
merged 1 commit into from May 8, 2018

Conversation

Projects
None yet
3 participants
@elyast
Copy link
Contributor

elyast commented May 7, 2018

Problem

Java/Scala doc generation is failing because by default class path includes only runtime scope, which poses a problem when user uses compile test scope

Solution

Since java/scala doc generation works mostly in compilation scope it seems reasonable to set class path to include compilation scope

Result

End user will not experience failed scaladoc generation, when using compile test scope

@stuhood

This comment has been minimized.

Copy link
Member

stuhood commented May 7, 2018

Thanks for doing this!

It's unfortunate that we didn't have an integration test for this, but I won't ask you to add it (unless you have time! it might look like cloning tests/python/pants_test/backend/jvm/tasks/test_jvm_run_integration.py to test_jvmdoc_gen_integration.py).

Will merge on green ci.

@elyast

This comment has been minimized.

Copy link
Contributor

elyast commented May 7, 2018

I can add integration tests as well, in the evening probably

@elyast elyast force-pushed the elyast:docgen_fix branch from dac5b8f to 145a20b May 7, 2018

@elyast

This comment has been minimized.

Copy link
Contributor

elyast commented May 7, 2018

Seems integration tests failed with read timeout:

Failed to fetch binary bin/gcc/linux/x86_64/7.3.0/gcc.tar.gz from any source: (Failed to fetch binary from https://binaries.pantsbuild.org/bin/gcc/linux/x86_64/7.3.0/gcc.tar.gz: Problem GETing data from https://binaries.pantsbuild.org/bin/gcc/linux/x86_64/7.3.0/gcc.tar.gz: HTTPSConnectionPool(host='binaries.pantsbuild.org', port=443): Read timed out. (read timeout=30))
@baroquebobcat

This comment has been minimized.

Copy link
Contributor

baroquebobcat commented May 7, 2018

I tried restarting the shard

@stuhood

This comment has been minimized.

Copy link
Member

stuhood commented May 8, 2018

@elyast : Do you still think you will have time to add a test? If not, I'll merge this.

@elyast

This comment has been minimized.

Copy link
Contributor

elyast commented May 8, 2018

@stuhood let's merge this, I will create a test for that later in a week in a separate patch

@stuhood stuhood merged commit 4bfcc5c into pantsbuild:master May 8, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@stuhood

This comment has been minimized.

Copy link
Member

stuhood commented May 8, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment