New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurable timeouts for reading/writing to remote cache #5793

Merged
merged 1 commit into from May 8, 2018

Conversation

Projects
None yet
2 participants
@stuhood
Copy link
Member

stuhood commented May 8, 2018

Problem

On busy networks or with sufficiently high concurrency and large artifacts, write timeouts were possible at the (hardcoded) 4 seconds.

Solution

Differentiate between reads and writes, and make both artifact cache timeouts configurable.

@stuhood stuhood requested review from benjyw , illicitonion , mateor and baroquebobcat May 8, 2018

@baroquebobcat
Copy link
Contributor

baroquebobcat left a comment

Looks good to me!

@stuhood stuhood merged commit 0d093cd into pantsbuild:master May 8, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stuhood stuhood deleted the twitter:stuhood/configurable-artifact-cache-timeouts branch May 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment