New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip commit hooks during publishing #5795

Merged
merged 3 commits into from May 9, 2018

Conversation

Projects
None yet
3 participants
@stuhood
Copy link
Member

stuhood commented May 9, 2018

Problem

In the pants repo, commit-hooks cause pants to deadlock on itself by linting and then failing to acquire the pantsbuild workdir lock.

Solution

Add an option to skip commit hooks during publishing.

stuhood added some commits May 9, 2018

Skip commit hooks during publishing. In the pants repo in particular,…
… these end up deadlocked on pants itself due to linting.

@stuhood stuhood requested review from ity , kwlzn and dotordogh May 9, 2018

@stuhood

This comment has been minimized.

Copy link
Member

stuhood commented May 9, 2018

I could imagine that I should toggle the default for this option, and then only skip commit verify in the pantsbuild repo... thoughts?

@stuhood stuhood requested review from benjyw and removed request for ity May 9, 2018

@kwlzn

kwlzn approved these changes May 9, 2018

Copy link
Member

kwlzn left a comment

I could imagine that I should toggle the default for this option, and then only skip commit verify in the pantsbuild repo... thoughts?

+1, otherwise LGTM

@benjyw

benjyw approved these changes May 9, 2018

@stuhood stuhood merged commit 9f20b89 into pantsbuild:master May 9, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stuhood stuhood deleted the twitter:stuhood/no-commit-hooks-in-publishing branch May 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment