New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a broken 3rdparty example. #5797

Merged
merged 1 commit into from May 9, 2018

Conversation

Projects
None yet
2 participants
@stuhood
Copy link
Member

stuhood commented May 9, 2018

Fix an example that was using a broken include, and use explicit comments to ensure it doesn't break again.

@stuhood stuhood requested review from benjyw , cosmicexplorer and dotordogh May 9, 2018

@stuhood

This comment has been minimized.

Copy link
Member

stuhood commented May 9, 2018

Before:
screen shot 2018-05-09 at 11 30 43 am

After
screen shot 2018-05-09 at 11 30 27 am

@benjyw

benjyw approved these changes May 9, 2018

@stuhood stuhood merged commit 0c5790f into pantsbuild:master May 9, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stuhood stuhood deleted the twitter:stuhood/fix-3rdparty-example branch May 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment