New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SelectDependencies. #5800

Merged
merged 4 commits into from May 14, 2018

Conversation

Projects
None yet
3 participants
@stuhood
Copy link
Member

stuhood commented May 10, 2018

Problem

SelectDependencies is harder to reason about, explain, and implement than it is to use the coroutine syntax and yield a list of Gets.

Solution

Replace usage of SelectDependencies with usage of coroutine @rules, and remove all references.

Result

Simplified code, and no impact on performance.

@stuhood stuhood force-pushed the pantsbuild:master branch from b6bb42d to 9e2fdb5 May 11, 2018

@stuhood stuhood force-pushed the twitter:stuhood/remove-select-dependencies branch from 4b1e462 to cc8a99c May 14, 2018

@stuhood stuhood changed the title WIP: Remove SelectDependencies. Remove SelectDependencies. May 14, 2018

@stuhood

This comment has been minimized.

Copy link
Member

stuhood commented May 14, 2018

This is now ready for review.

@illicitonion
Copy link
Contributor

illicitonion left a comment

Simpler is better! Hurrah!

@illicitonion illicitonion merged commit 2d56d4d into pantsbuild:master May 14, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@baroquebobcat

This comment has been minimized.

Copy link
Contributor

baroquebobcat commented May 15, 2018

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment