New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jvm compile subsystem #5805

Merged
merged 2 commits into from May 10, 2018

Conversation

Projects
None yet
2 participants
@cheister
Copy link
Contributor

cheister commented May 10, 2018

Problem

Address feedback from #5743 to remove JvmCompileSubsystem, fix BUILD files and add integration test for javac

Result

You can now configure the compiler in pants.ini with

[jvm-platform]
compiler: javac

And there is a base integration test for javac compilation. I imagine we'll want more tests in the future.

@cheister cheister requested a review from stuhood May 10, 2018

@cheister cheister changed the title Remove compile subsystem Remove jvm compile subsystem May 10, 2018

@stuhood
Copy link
Member

stuhood left a comment

Thanks!

@stuhood

This comment has been minimized.

Copy link
Member

stuhood commented May 10, 2018

I'll rebase #4729 atop this, so please land as soon as you have green CI.

@cheister cheister force-pushed the cheister:remove-compile-subsystem branch from 75fbcd0 to 116c4fb May 10, 2018

@cheister cheister merged commit e535b3c into pantsbuild:master May 10, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@cheister cheister deleted the cheister:remove-compile-subsystem branch May 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment