New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshot contains a DirectoryDigest #5811

Merged
merged 2 commits into from May 14, 2018

Conversation

Projects
None yet
2 participants
@illicitonion
Copy link
Contributor

illicitonion commented May 11, 2018

This better encapsulates the data, and will make it simpler to
differentiate between, and traverse across, places where we use each
type.

Also:

  • Stop double-hexifying fingerprints. We pass the hex version up from
    rust to python, so we shouldn't hexify that.
  • Use shared code for type checks.
  • Add proper error handling when lifting Digests and ExecuteProcesses.
  • Take dicts on the python side for env, not tuples - do the
    translation as a serialization stage, not as part of the interface.

@illicitonion illicitonion force-pushed the twitter:dwagnerhall/snapshot-to-digest/0 branch from 4e5d491 to acaa038 May 11, 2018

@stuhood
Copy link
Member

stuhood left a comment

Thanks.

@stuhood stuhood force-pushed the pantsbuild:master branch from b6bb42d to 9e2fdb5 May 11, 2018

@stuhood stuhood force-pushed the twitter:dwagnerhall/snapshot-to-digest/0 branch from acaa038 to 8b7dbf3 May 13, 2018

@stuhood

This comment has been minimized.

Copy link
Member

stuhood commented May 13, 2018

(rebased this to get a useful travis run)

illicitonion added some commits May 11, 2018

Snapshot contains a DirectoryDigest
This better encapsulates the data, and will make it simpler to
differentiate between, and traverse across, places where we use each
type.

Also:
 * Stop double-hexifying fingerprints. We pass the hex version up from
   rust to python, so we shouldn't hexify that.
 * Use shared code for type checks.
 * Add proper error handling when lifting Digests and ExecuteProcesses.
 * Take dicts on the python side for env, not tuples - do the
   translation as a serialization stage, not as part of the interface.

@illicitonion illicitonion force-pushed the twitter:dwagnerhall/snapshot-to-digest/0 branch from 8b7dbf3 to b76ac82 May 14, 2018

@illicitonion illicitonion merged commit f763f58 into pantsbuild:master May 14, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@illicitonion illicitonion deleted the twitter:dwagnerhall/snapshot-to-digest/0 branch Aug 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment