New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalidate all task outputs on source root changes. #5821

Merged
merged 1 commit into from May 16, 2018

Conversation

Projects
None yet
3 participants
@benjyw
Copy link
Contributor

benjyw commented May 14, 2018

Prior to this change, modifying source roots did not cause any invalidation, which is obviously a bug.

Invalidating everything may be a bit aggressive, but finessing exactly what would need to be invalidated in each case is tricky, and source root changes are infrequent, so this seems fine.

Invalidate all tasks on source root changes.
It's a bit aggressive, but finessing exactly what needs
to be invalidated in each case is tricky, and this is far
better than the current situation, where we invalidate
nothing on source root changes - this is a clear bug.

@benjyw benjyw requested review from stuhood and jsirois May 14, 2018

@baroquebobcat
Copy link
Contributor

baroquebobcat left a comment

Looks good to me!

@benjyw benjyw merged commit 0b6e32f into pantsbuild:master May 16, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@benjyw benjyw deleted the benjyw:invalidate_on_source_root_changes branch May 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment