New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release.sh] Use git configured gpg binary if one is set #5826

Merged
merged 1 commit into from May 15, 2018

Conversation

Projects
None yet
3 participants
@baroquebobcat
Copy link
Contributor

baroquebobcat commented May 14, 2018

For some reason, my local install of gpg includes both gpg 2 and gpg v1. When I run with the command gpg, I get gpg v1. My keys are setup by gpg v2. That's on my path as gpg2.

I setup git so that git knows to use gpg2, but pants' release doesn't.

This patch changes release.sh to look up the gpg binary from git's config, just like the signing key.

[release.sh] Use git configured gpg binary if one is set
For some reason, my local install of gpg includes both gpg 2 and gpg v1. When I run with the command gpg, I get gpg v1. My keys are setup by gpg v2. That's on my path as gpg2.

I setup git so that git knows to use gpg2, but pants' release doesn't.

This patch changes release.sh to look up the gpg binary from gits config, just like the signing key.
@kwlzn

kwlzn approved these changes May 14, 2018

@baroquebobcat baroquebobcat merged commit db0ed3d into pantsbuild:master May 15, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment